C++: Make AST GVN a wrapper for IR-based GVN #2724
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasVP
changed the title
MathiasVP
force-pushed
the
rdmarsh2/rdmarsh/cpp/ir-gvn-ast-wrapper
branch
from
d91dfb7 to
dee1f24
Compare
rdmarsh2
suggested changes
Jan 30, 2020
cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/gvn/ValueNumbering.qll
Show resolved
Hide resolved
cpp/ql/test/library-tests/valuenumbering/GlobalValueNumbering/ir_uniqueness.ql
Outdated
Show resolved
Hide resolved
csharp/ql/src/semmle/code/csharp/ir/implementation/raw/gvn/internal/ValueNumberingImports.qll
Outdated
Show resolved
Hide resolved
...rc/semmle/code/csharp/ir/implementation/unaliased_ssa/gvn/internal/ValueNumberingImports.qll
Outdated
Show resolved
Hide resolved
cpp/ql/test/library-tests/valuenumbering/GlobalValueNumbering/ir_uniqueness.expected
Outdated
Show resolved
Hide resolved
...ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/gvn/internal/ValueNumberingInternal.qll
Show resolved
Hide resolved
...ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/gvn/internal/ValueNumberingInternal.qll
Show resolved
Hide resolved
…ernal/ValueNumberingImports.qll Co-Authored-By: Robert Marsh <[email protected]>
…sa/gvn/internal/ValueNumberingImports.qll Co-Authored-By: Robert Marsh <[email protected]>
…nternal/ValueNumberingInternal.qll Co-Authored-By: Robert Marsh <[email protected]>
…nternal/ValueNumberingInternal.qll Co-Authored-By: Robert Marsh <[email protected]>
MathiasVP
force-pushed
the
rdmarsh2/rdmarsh/cpp/ir-gvn-ast-wrapper
branch
from
eefaf4c to
8b91c2d
Compare
jbj
reviewed
Jan 31, 2020
cpp/ql/test/library-tests/valuenumbering/GlobalValueNumbering/ir_gvn.expected
Outdated
Show resolved
Hide resolved
…ue to the hasLocationInfo not picked the 'smallest' location (as Robert suggested we should do)
jbj
reviewed
Feb 3, 2020
cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/gvn/ValueNumbering.qll
Show resolved
Hide resolved
…tDebugString. Instead, call that one in the AST wrapper
…e which have AST representations are numbered
rdmarsh2
reviewed
Feb 3, 2020
...rc/semmle/code/csharp/ir/implementation/unaliased_ssa/gvn/internal/ValueNumberingImports.qll
Outdated
Show resolved
Hide resolved
… to prevent the sync script from complaining
jbj
reviewed
Feb 4, 2020
cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/gvn/ValueNumbering.qll
Outdated
Show resolved
Hide resolved
… with a given value number. Also added a getKind for the AST value numbering implementation with the same behavior as the IR value numbering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues the work in #1542 by:
toString()asresult = "GVN"hasLocation()predicategetKind()getAnExpr()